Skip to content

ref(node22): Using Promise.withResolvers()#3268

Merged
RobinTail merged 1 commit intomake-v28from
ref-with-resolvers
Mar 21, 2026
Merged

ref(node22): Using Promise.withResolvers()#3268
RobinTail merged 1 commit intomake-v28from
ref-with-resolvers

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented Mar 19, 2026

The feature introduced in Node 22.0.0

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Mar 19, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 19, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee603b4a-257c-498b-9fc0-15b0ba2611c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ref-with-resolvers
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RobinTail RobinTail added this to the v28 milestone Mar 19, 2026
@RobinTail RobinTail marked this pull request as ready for review March 19, 2026 05:59
@RobinTail RobinTail mentioned this pull request Mar 19, 2026
Open
pullfrog[bot]
pullfrog Bot reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-scoped refactoring. engines already requires ^22.18.0 || ^24.0.0, CI confirms Node 22.18.0+ support, all new Promise( usages in src/ are migrated, and the implementation is correct. No issues found.

Pullfrog  ｜ View workflow run ｜ pullfrog.com ｜ 𝕏

@RobinTail RobinTail merged commit 495053c into make-v28 Mar 21, 2026
12 checks passed
@RobinTail RobinTail deleted the ref-with-resolvers branch March 21, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pullfrog pullfrog[bot] pullfrog[bot] left review comments

Assignees

No one assigned

Labels

refactoring The better way to achieve the same result

Projects

None yet

Milestone

v28

Development

Successfully merging this pull request may close these issues.

1 participant

@RobinTail